feat(1769): [3] Modify webhook plugin to use queue webhook #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yk634
changed the title
yk634
commented
Jan 7, 2022
itleigns
previously approved these changes
Jan 7, 2022
kumada626
reviewed
Jan 10, 2022
…is not implemented
kumada626
approved these changes
Jan 11, 2022
jithine
approved these changes
Jan 11, 2022
tkyi
approved these changes
Jan 11, 2022
|
This PR is included in version 4.1.185 The release is available on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is the implementation that follows #2622.
I modify the webhook plugin to POST the webhook received from SCM to the queue service endpoint
/v1/queue/message?type=webhookwhenqueueWebhookEnabledis true.Objective
queueWebhookEnabledto config so that users can choose whether or not to queue the webhook.queueWebhooktoserver.appso that the following items can be used from the plugins.executor.enqueueWebhookmethod to POST to/v1/queue/message?type=webhookto be executed according to thequeueWebhookEnabledsetting.References
Please do not merge this PR until after the following PRs have been merged.
#1769 (comment)
License
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.